Code Review for open

Prepared by:herrick on Fri Sep 6 16:07:35 EDT 2019
Workspace:/home/aherrick/sandbox/open
Branch:JDK-8200758-branch
Summary of changes: 233 lines changed: 151 ins; 20 del; 62 mod; 10720 unchg
Patch of changes: open.patch
Bug id: JDK-8230519 : jpackage "--package-type" values and default
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppBundler.java

6 lines changed: 6 ins; 0 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java

19 lines changed: 19 ins; 0 del; 0 mod; 942 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

6 lines changed: 6 ins; 0 del; 0 mod; 705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties

3 lines changed: 0 ins; 0 del; 3 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_ja.properties

3 lines changed: 0 ins; 0 del; 3 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_zh_CN.properties

3 lines changed: 0 ins; 0 del; 3 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppBundler.java

5 lines changed: 5 ins; 0 del; 0 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java

6 lines changed: 6 ins; 0 del; 0 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java

6 lines changed: 6 ins; 0 del; 0 mod; 469 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgBundler.java

5 lines changed: 5 ins; 0 del; 0 mod; 544 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_ja.properties

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

23 lines changed: 9 ins; 4 del; 10 mod; 780 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Bundler.java

5 lines changed: 5 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java

5 lines changed: 0 ins; 1 del; 4 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java

7 lines changed: 4 ins; 0 del; 3 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties

7 lines changed: 0 ins; 1 del; 6 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties

7 lines changed: 0 ins; 1 del; 6 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties

7 lines changed: 0 ins; 1 del; 6 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java

5 lines changed: 5 ins; 0 del; 0 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

5 lines changed: 5 ins; 0 del; 0 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

6 lines changed: 6 ins; 0 del; 0 mod; 1171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties

6 lines changed: 0 ins; 4 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties

6 lines changed: 0 ins; 4 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties

6 lines changed: 0 ins; 4 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/macosx/BundleIdentifierTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/macosx/BundleNameTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddLauncherModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddLauncherTest.java

1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddLaunchersTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddModulesTest.java

3 lines changed: 3 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AppVersionTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ArgumentsModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ArgumentsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AtFilenameTest.java

1 line changed: 1 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ErrorTest.java

6 lines changed: 4 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/IconTest.java

1 line changed: 1 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/InvalidArgTest.java

10 lines changed: 6 ins; 0 del; 4 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/JLinkModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/JavaOptionsEqualsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/JavaOptionsModuleTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/JavaOptionsTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/MainClassAttributeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/MainClassErrorTest.java

1 line changed: 1 ins; 0 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/MissingArgumentsTest.java

6 lines changed: 6 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ModularJarTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ModuleMainClassErrorTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ModulePathTest.java

3 lines changed: 3 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ModuleTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/NoNameTest.java

1 line changed: 1 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ResourceTest.java

1 line changed: 1 ins; 0 del; 0 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimeModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimeTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/TempRootTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/Test.java

1 line changed: 1 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/VerboseTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/WithSpaceTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinConsoleTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 136 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).