Code Review for graal

Prepared by:vvenkata on Thu Oct 31 16:00:28 CDT 2013
Workspace:/home/tester/graalrepos/default-10-28-2013-shiftop-neg/graal
Compare against: http://10.181.37.176:8080/scm/hg/graal/graal
Compare against version:default-10-28-2013
Branch:default-10-28-2013-shiftop-neg
Summary of changes: 1315 lines changed: 1215 ins; 49 del; 51 mod; 1721 unchg
Patch of changes: graal.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.asm.hsail/src/com/oracle/graal/asm/hsail/HSAILAssembler.java 

rev 13212 : Renamed the cmovCommon method.
Refactored the emitTextFormattedInstruction( ) ruotine to use a switch statement over the number of source operands.
79 lines changed: 49 ins; 4 del; 26 mod; 352 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.compiler.hsail/src/com/oracle/graal/compiler/hsail/HSAILLIRGenerator.java 

rev 13211 : Made some stylistic changes.
Extended some tests to handle negative numbers.
74 lines changed: 72 ins; 1 del; 1 mod; 732 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.lir.hsail/src/com/oracle/graal/lir/hsail/HSAILArithmetic.java 

rev 13213 : Alphabetized the enum opcodes in HSAILArithmetic
133 lines changed: 66 ins; 44 del; 23 mod; 368 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.lir.hsail/src/com/oracle/graal/lir/hsail/HSAILControlFlow.java 

rev 13212 : Renamed the cmovCommon method.
Refactored the emitTextFormattedInstruction( ) ruotine to use a switch statement over the number of source operands.
1 line changed: 0 ins; 0 del; 1 mod; 269 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/DoubleNegTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/FloatNegTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntBitwiseNotTest.java 

rev 13211 : Made some stylistic changes.
Extended some tests to handle negative numbers.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntBitwiseShiftLeftTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntBitwiseShiftRightTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntBitwiseShiftRightUnsignedTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntNegTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/LongBitwiseNotTest.java 

rev 13211 : Made some stylistic changes.
Extended some tests to handle negative numbers.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/LongBitwiseShiftLeftTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/LongBitwiseShiftRightTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/LongBitwiseShiftRightUnsignedTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/LongNegTest.java 

rev 13214 : added comments to test cases indicating the instruction mnemonics produced.
81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /bin/webrev.ksh (vers 24.0-hg+jbs).