Code Review for nashorn

Prepared by: U-SATHIJEG-IN\sathijeg (SATHIJEG-IN+sathijeg) on Wed Jul 29 10:47:21 IST 2015
Workspace:/cygdrive/d/src/jdk8u-dev/nashorn
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn
Compare against version:1474
Summary of changes: 693 lines changed: 365 ins; 303 del; 25 mod; 12225 unchg
Changeset: nashorn.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/AssignSymbols.java

rev 1479 : 8131683: Delete fails over multiple scopes
Reviewed-by: mhaupt, sundar
6 lines changed: 4 ins; 1 del; 1 mod; 1060 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/codegen/DumpBytecode.java

rev 1475 : 8130424: if directory specified with --dest-dir does not exist, only .class files are dumped and .js files are not
Reviewed-by: attila, lagergren, hannesw
1 line changed: 0 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/ir/RuntimeNode.java

rev 1479 : 8131683: Delete fails over multiple scopes
Reviewed-by: mhaupt, sundar
2 lines changed: 2 ins; 0 del; 0 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/objects/Global.java

rev 1476 : 8130476: Remove unused methods in Global.java
Reviewed-by: hannesw, attila
rev 1480 : 8130853: Non-extensible global is not handled property
Reviewed-by: jlaskey, hannesw
273 lines changed: 1 ins; 268 del; 4 mod; 2741 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/FinalScriptFunctionData.java

rev 1478 : 8131340: Varargs function is recompiled each time it is linked
Reviewed-by: mhaupt, sundar
20 lines changed: 15 ins; 5 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/JSONFunctions.java

rev 1477 : 8131039: after adding a function property to Object.prototype, JSON.parse with reviver function goes into infinite loop
Reviewed-by: hannesw, mhaupt
20 lines changed: 12 ins; 0 del; 8 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/RecompilableScriptFunctionData.java

rev 1478 : 8131340: Varargs function is recompiled each time it is linked
Reviewed-by: mhaupt, sundar
29 lines changed: 16 ins; 11 del; 2 mod; 825 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptFunctionData.java

rev 1478 : 8131340: Varargs function is recompiled each time it is linked
Reviewed-by: mhaupt, sundar
22 lines changed: 0 ins; 18 del; 4 mod; 862 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptObject.java

rev 1480 : 8130853: Non-extensible global is not handled property
Reviewed-by: jlaskey, hannesw
12 lines changed: 10 ins; 0 del; 2 mod; 3798 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/ScriptRuntime.java

rev 1479 : 8131683: Delete fails over multiple scopes
Reviewed-by: mhaupt, sundar
27 lines changed: 27 ins; 0 del; 0 mod; 1026 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk/nashorn/internal/runtime/Source.java

rev 1475 : 8130424: if directory specified with --dest-dir does not exist, only .class files are dumped and .js files are not
Reviewed-by: attila, lagergren, hannesw
9 lines changed: 6 ins; 0 del; 3 mod; 1005 unchg

------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8130853.js

rev 1480 : 8130853: Non-extensible global is not handled property
Reviewed-by: jlaskey, hannesw
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8131039.js

rev 1477 : 8131039: after adding a function property to Object.prototype, JSON.parse with reviver function goes into infinite loop
Reviewed-by: hannesw, mhaupt
35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8131340.js

rev 1478 : 8131340: Varargs function is recompiled each time it is linked
Reviewed-by: mhaupt, sundar
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8131683.js

rev 1479 : 8131683: Delete fails over multiple scopes
Reviewed-by: mhaupt, sundar
89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/script/basic/JDK-8131683.js.EXPECTED

rev 1479 : 8131683: Delete fails over multiple scopes
Reviewed-by: mhaupt, sundar
16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../webrev/webrev.ksh (vers 25.11-hg+openjdk.java.net).