Code Review for nashorn

Prepared by:sundar on Mon Apr 6 11:37:28 IST 2015
Workspace:/home/sundar/src/jdk8u-dev/nashorn
Summary of changes: 73 lines changed: 29 ins; 0 del; 44 mod; 9750 unchg
Patch of changes: nashorn.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/build.xml

4 lines changed: 0 ins; 0 del; 4 mod; 729 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/script/sandbox/interfaceimpl.js

2 lines changed: 0 ins; 0 del; 2 mod; 61 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/script/trusted/JDK-8025629.js

1 line changed: 0 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/META-INF/services/java.sql.Driver

1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/internal/dynalink/beans/test/CallerSensitiveTest.java (was test/src/jdk/internal/dynalink/beans/CallerSensitiveTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/ArrayConversionTest.java (was test/src/jdk/nashorn/api/javaaccess/ArrayConversionTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/BooleanAccessTest.java (was test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 218 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/ConsStringTest.java (was test/src/jdk/nashorn/api/javaaccess/ConsStringTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/MethodAccessTest.java (was test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 465 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/NumberAccessTest.java (was test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 788 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/NumberBoxingTest.java (was test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 364 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/ObjectAccessTest.java (was test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/Person.java (was test/src/jdk/nashorn/api/javaaccess/Person.java)

1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/SharedObject.java (was test/src/jdk/nashorn/api/javaaccess/SharedObject.java)

1 line changed: 0 ins; 0 del; 1 mod; 466 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/javaaccess/test/StringAccessTest.java (was test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/InvocableTest.java (was test/src/jdk/nashorn/api/scripting/InvocableTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 538 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/MultipleEngineTest.java (was test/src/jdk/nashorn/api/scripting/MultipleEngineTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/PluggableJSObjectTest.java (was test/src/jdk/nashorn/api/scripting/PluggableJSObjectTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 287 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/ScopeTest.java (was test/src/jdk/nashorn/api/scripting/ScopeTest.java)

3 lines changed: 2 ins; 0 del; 1 mod; 778 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/ScriptEngineSecurityTest.java (was test/src/jdk/nashorn/api/scripting/ScriptEngineSecurityTest.java)

3 lines changed: 2 ins; 0 del; 1 mod; 310 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/ScriptEngineTest.java (was test/src/jdk/nashorn/api/scripting/ScriptEngineTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 879 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/ScriptObjectMirrorTest.java (was test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java)

3 lines changed: 2 ins; 0 del; 1 mod; 386 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/VariableArityTestInterface.java (was test/src/jdk/nashorn/api/scripting/VariableArityTestInterface.java)

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/Window.java (was test/src/jdk/nashorn/api/scripting/Window.java)

3 lines changed: 2 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/scripting/test/WindowEventHandler.java (was test/src/jdk/nashorn/api/scripting/WindowEventHandler.java)

1 line changed: 0 ins; 0 del; 1 mod; 30 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/src/jdk/nashorn/api/scripting/test/resources/func.js (was test/src/jdk/nashorn/api/scripting/resources/func.js)

0 lines changed: 0 ins; 0 del; 0 mod; 42 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/src/jdk/nashorn/api/scripting/test/resources/gettersetter.js (was test/src/jdk/nashorn/api/scripting/resources/gettersetter.js)

0 lines changed: 0 ins; 0 del; 0 mod; 38 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/src/jdk/nashorn/api/scripting/test/resources/witheval.js (was test/src/jdk/nashorn/api/scripting/resources/witheval.js)

0 lines changed: 0 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/api/test/NashornSQLDriver.java (was test/src/jdk/nashorn/api/NashornSQLDriver.java)

1 line changed: 0 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/codegen/test/CompilerTest.java (was test/src/jdk/nashorn/internal/codegen/CompilerTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 208 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/parser/test/ParserTest.java (was test/src/jdk/nashorn/internal/parser/ParserTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 188 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/regexp/joni/test/JoniTest.java (was test/src/jdk/nashorn/internal/runtime/regexp/joni/JoniTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/regexp/test/JdkRegExpTest.java (was test/src/jdk/nashorn/internal/runtime/regexp/JdkRegExpTest.java)

4 lines changed: 3 ins; 0 del; 1 mod; 59 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ClassFilterTest.java (was test/src/jdk/nashorn/internal/runtime/ClassFilterTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/CodeStoreAndPathTest.java (was test/src/jdk/nashorn/internal/runtime/CodeStoreAndPathTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 187 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ConsStringTest.java (was test/src/jdk/nashorn/internal/runtime/ConsStringTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ContextTest.java (was test/src/jdk/nashorn/internal/runtime/ContextTest.java)

7 lines changed: 6 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/ExceptionsNotSerializable.java (was test/src/jdk/nashorn/internal/runtime/ExceptionsNotSerializable.java)

3 lines changed: 2 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/JSTypeTest.java (was test/src/jdk/nashorn/internal/runtime/JSTypeTest.java)

3 lines changed: 2 ins; 0 del; 1 mod; 192 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/LexicalBindingTest.java (was test/src/jdk/nashorn/internal/runtime/LexicalBindingTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/NoPersistenceCachingTest.java (was test/src/jdk/nashorn/internal/runtime/NoPersistenceCachingTest.java)

1 line changed: 0 ins; 0 del; 1 mod; 139 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/SourceTest.java (was test/src/jdk/nashorn/internal/runtime/SourceTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/src/jdk/nashorn/internal/runtime/test/TrustedScriptEngineTest.java (was test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java)

2 lines changed: 1 ins; 0 del; 1 mod; 361 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/src/jdk/nashorn/internal/runtime/test/resources/load_test.js (was test/src/jdk/nashorn/internal/runtime/resources/load_test.js)

0 lines changed: 0 ins; 0 del; 0 mod; 28 unchg

This code review page was prepared using /home/sundar/src/webrev/webrev.ksh (vers 25.5-hg+openjdk.java.net).