Code Review for open

Prepared by:stefank on Tue Feb 20 23:18:05 CET 2018
Workspace:/home/stefank/hg/jdk/hs/open
Compare against version:qparent
Summary of changes: 3627 lines changed: 1829 ins; 1608 del; 190 mod; 52949 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsArguments.cpp

11 lines changed: 9 ins; 1 del; 1 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsArguments.hpp

8 lines changed: 4 ins; 2 del; 2 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.cpp

17 lines changed: 10 ins; 4 del; 3 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.hpp

8 lines changed: 6 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

17 lines changed: 2 ins; 7 del; 8 mod; 8145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp

9 lines changed: 0 ins; 6 del; 3 mod; 1794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 1490 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/parNewGeneration.hpp

1 line changed: 0 ins; 0 del; 1 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.cpp

31 lines changed: 29 ins; 1 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Arguments.hpp

6 lines changed: 4 ins; 2 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

38 lines changed: 10 ins; 14 del; 14 mod; 5316 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

13 lines changed: 8 ins; 1 del; 4 mod; 1513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullCollector.cpp

1 line changed: 0 ins; 1 del; 0 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FullGCScope.cpp

1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/adjoiningGenerations.cpp

33 lines changed: 1 ins; 8 del; 24 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/adjoiningGenerations.hpp

3 lines changed: 1 ins; 1 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/asPSOldGen.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/asPSYoungGen.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/generationSizer.cpp

44 lines changed: 0 ins; 44 del; 0 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelArguments.cpp

46 lines changed: 43 ins; 1 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelArguments.hpp

8 lines changed: 5 ins; 1 del; 2 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp

8 lines changed: 0 ins; 1 del; 7 mod; 704 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp

17 lines changed: 8 ins; 2 del; 7 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/pcTasks.hpp

1 line changed: 1 ins; 0 del; 0 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp

1 line changed: 0 ins; 1 del; 0 mod; 1136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp

5 lines changed: 1 ins; 0 del; 4 mod; 668 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp

5 lines changed: 1 ins; 0 del; 4 mod; 3181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psScavenge.cpp

4 lines changed: 1 ins; 1 del; 2 mod; 781 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psYoungGen.cpp

1 line changed: 0 ins; 0 del; 1 mod; 900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/defNewGeneration.cpp

13 lines changed: 2 ins; 4 del; 7 mod; 1035 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/defNewGeneration.hpp

4 lines changed: 3 ins; 0 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/genMarkSweep.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialArguments.cpp

10 lines changed: 8 ins; 1 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialArguments.hpp

6 lines changed: 3 ins; 1 del; 2 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialHeap.cpp

14 lines changed: 12 ins; 0 del; 2 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialHeap.hpp

6 lines changed: 4 ins; 1 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/tenuredGeneration.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/tenuredGeneration.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp

6 lines changed: 2 ins; 1 del; 3 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/ageTable.cpp

2 lines changed: 0 ins; 2 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

8 lines changed: 8 ins; 0 del; 0 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.hpp

10 lines changed: 7 ins; 1 del; 2 mod; 636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.cpp

91 lines changed: 91 ins; 0 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.hpp

6 lines changed: 4 ins; 0 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/gcArguments.inline.hpp

11 lines changed: 0 ins; 11 del; 0 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

331 lines changed: 298 ins; 2 del; 31 mod; 1125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

57 lines changed: 44 ins; 5 del; 8 mod; 464 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generation.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generationSpec.cpp

9 lines changed: 0 ins; 5 del; 4 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/generationSpec.hpp

5 lines changed: 2 ins; 2 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/vmGCOperations.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.cpp

80 lines changed: 76 ins; 1 del; 3 mod; 4677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspace.hpp

6 lines changed: 5 ins; 1 del; 0 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/precompiled/precompiled.hpp

1 line changed: 0 ins; 1 del; 0 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp

9 lines changed: 3 ins; 0 del; 6 mod; 2155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

1 line changed: 0 ins; 0 del; 1 mod; 4593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/commandLineFlagConstraintsGC.cpp

5 lines changed: 1 ins; 0 del; 4 mod; 806 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 3511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/shared/test_collectorPolicy.cpp

3 lines changed: 2 ins; 1 del; 0 mod; 285 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/cms/cmsSettings.cpp

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/cms/cmsSettings.hpp

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1Settings.cpp

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1Settings.hpp

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/parallel/psSettings.cpp

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/parallel/psSettings.hpp

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/serial/serialSettings.cpp

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/serial/serialSettings.hpp

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/gcSettings.cpp

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/gcSettings.hpp

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/genArguments.cpp

400 lines changed: 400 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/genArguments.hpp

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/genSettings.cpp

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/genSettings.hpp

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/softRefGenPolicy.cpp

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/softRefGenPolicy.hpp

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/softRefPolicy.cpp

41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/softRefPolicy.hpp

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/cms/cmsCollectorPolicy.cpp

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/cms/cmsCollectorPolicy.hpp

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1CollectorPolicy.cpp

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/g1/g1CollectorPolicy.hpp

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/parallel/generationSizer.hpp

51 lines changed: 0 ins; 51 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/shared/collectorPolicy.cpp

917 lines changed: 0 ins; 917 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/shared/collectorPolicy.hpp

277 lines changed: 0 ins; 277 del; 0 mod; 0 unchg

This code review page was prepared using /home/stefank/hg/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).