Code Review for openjdk-head-2

Prepared by:Severin Gehwolf on Mon Oct 14 20:38:43 CEST 2019
Workspace:/disk/openjdk/upstream-sources/openjdk-head-2
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:ddffb7c3a4a2
Summary of changes: 598 lines changed: 552 ins; 25 del; 21 mod; 3808 unchg
Patch of changes: openjdk-head-2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.cpp 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56575 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
206 lines changed: 167 ins; 24 del; 15 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.hpp 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56575 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
17 lines changed: 17 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
16 lines changed: 16 ins; 0 del; 0 mod; 2414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/cgroup/PlainRead.java 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/PrintContainerInfo.java 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
5 lines changed: 5 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/TestCPUAwareness.java 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
25 lines changed: 22 ins; 0 del; 3 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/TestMisc.java 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
19 lines changed: 16 ins; 1 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/sun/hotspot/WhiteBox.java 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
7 lines changed: 7 ins; 0 del; 0 mod; 555 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp 

@  rev 56576 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).