Code Review for jdk

Prepared by:Severin Gehwolf on Fri Jan 8 15:03:37 CET 2021
Workspace:/disk/openjdk/upstream-sources/openjdk8u-dev/jdk
Compare against: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk
Compare against version:cc8a56b27204
Summary of changes: 836 lines changed: 595 ins; 38 del; 203 mod; 17241 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/tools/jarsigner/Main.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
:  Reviewed-by: mullan, weijun
:  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14329 : 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"
|  Reviewed-by: mullan
~
217 lines changed: 131 ins; 30 del; 56 mod; 2749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/tools/jarsigner/Resources.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
:  Reviewed-by: mullan, weijun
:  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14329 : 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"
|  Reviewed-by: mullan
~
14 lines changed: 12 ins; 0 del; 2 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/tools/keytool/Main.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
o  rev 14329 : 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"
|  Reviewed-by: mullan
~
47 lines changed: 27 ins; 7 del; 13 mod; 4529 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/tools/keytool/Resources.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
:  Reviewed-by: mullan, weijun
:  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14329 : 8185934: keytool shows "Signature algorithm: SHA1withECDSA, -1-bit key"
|  Reviewed-by: mullan
~
7 lines changed: 4 ins; 0 del; 3 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
5 lines changed: 4 ins; 1 del; 0 mod; 946 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/security/java.security-aix

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
20 lines changed: 20 ins; 0 del; 0 mod; 1173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/security/java.security-linux

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
20 lines changed: 20 ins; 0 del; 0 mod; 1179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/security/java.security-macosx

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
20 lines changed: 20 ins; 0 del; 0 mod; 1177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/security/java.security-solaris

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
20 lines changed: 20 ins; 0 del; 0 mod; 1175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/lib/security/java.security-windows

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
|  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
o  rev 14330 : 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
|  Reviewed-by: mullan, xuelei, weijun
~
20 lines changed: 20 ins; 0 del; 0 mod; 1177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/TimestampCheck.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
169 lines changed: 133 ins; 0 del; 36 mod; 868 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/TsacertOptionTest.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
2 lines changed: 0 ins; 0 del; 2 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/Warning.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
4 lines changed: 0 ins; 0 del; 4 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/concise_jarsigner.sh

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
3 lines changed: 0 ins; 0 del; 3 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/ec.sh

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
2 lines changed: 0 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/jarsigner/nameclash.sh

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
3 lines changed: 0 ins; 0 del; 3 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/security/tools/keytool/WeakAlg.java

@  rev 14333 : 8172404: Tools should warn if weak algorithms are used before restricting them
|  Reviewed-by: mullan, weijun
~  Contributed-by: Hai-May Chao <hai-may.chao@oracle.com>
263 lines changed: 184 ins; 0 del; 79 mod; 679 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.18-hg+openjdk.java.net).