Code Review for jdk

Prepared by:serb on Fri Jan 15 01:47:13 MSK 2016
Workspace:/Users/serb/moe/workspaces/jdk/9/client-work/jdk
Compare against: /Users/serb/moe/workspaces/jdk/9/client-gate/jdk
Compare against version:13442
Summary of changes: 107 lines changed: 57 ins; 35 del; 15 mod; 842 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/META-INF/services/javax.sound.sampled.spi.AudioFileReader 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
rev 10520 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
1 line changed: 1 ins; 0 del; 0 mod; 6 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
rev 12447 : 8013586: audioInputStream.close() does not release the resource
8130305: AudioSystem behavior depends on order that providers are located
Reviewed-by: prr, amenkov
rev 11093 : 8067207: Replace concat String to append in StringBuilder parameters (client)
Reviewed-by: serb
Contributed-by: Otavio Santana <otaviojava@java.net>
rev 10520 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
5 lines changed: 0 ins; 1 del; 4 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/WaveFileFormat.java 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
rev 10520 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
15 lines changed: 1 ins; 8 del; 6 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/WaveFileWriter.java 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
rev 13442 : 8064800: AudioSystem/WaveFileWriter can't write PCM_FLOAT, but writes it anyway
Reviewed-by: XXX
rev 13121 : 8135100: Behavior of null arguments not specified in javax.sound.sampled.spi
Summary: The specification change was reviewed by Florian Bomers also
Reviewed-by: amenkov
rev 10520 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
29 lines changed: 0 ins; 26 del; 3 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/WaveFloatFileReader.java 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
rev 12447 : 8013586: audioInputStream.close() does not release the resource
8130305: AudioSystem behavior depends on order that providers are located
Reviewed-by: prr, amenkov
rev 10520 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
3 lines changed: 1 ins; 0 del; 2 mod; 109 unchg

------ ------ ------ ------ --- New Patch Raw test/javax/sound/sampled/spi/AudioFileReader/RecognizeWaveExtensible.java 

rev 13443 : 8147407: Provide support of WaveExtensible sound format
Reviewed-by: XXX
54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/serb/moe/workspaces/tools/webrev/webrev.ksh (vers 25.12-hg+openjdk.java.net).