--- old/src/hotspot/share/gc/g1/g1NUMA.hpp 2019-10-15 07:17:53.758090883 -0700 +++ new/src/hotspot/share/gc/g1/g1NUMA.hpp 2019-10-15 07:17:53.390090872 -0700 @@ -44,14 +44,11 @@ // Total number of node ids. uint _num_active_node_ids; - // Base address of Java heap - void* _base_address; // HeapRegion size size_t _region_size; // Necessary when touching memory. size_t _page_size; - void* base_address() const; size_t region_size() const; size_t page_size() const; @@ -78,11 +75,11 @@ ~G1NUMA(); - // Set base address of heap, heap region size and page size after those values - // are determined at G1CollectedHeap::initialize(). - void set_region_info(void* base_address, size_t region_size, size_t page_size); + // Sets heap region size and page size after those values + // are determined at G1CollectedHeap::initialize(). + void set_region_info(size_t region_size, size_t page_size); - // Print current active memory node count. + // Returns active memory node count. uint num_active_nodes() const; bool is_enabled() const; @@ -101,7 +98,7 @@ // Result is less than num_active_nodes(). uint preferred_node_index_for_index(uint region_index) const; - // Retrieve node index of the given address. + // Retrieves node index of the given address. // Result is less than num_active_nodes() or is UnknownNodeIndex. // Precondition: address is in reserved range for heap. uint index_of_address(HeapWord* address) const; @@ -110,8 +107,8 @@ // If disabled, return preferred node index of the given heap region. uint index_for_region(HeapRegion* hr) const; - // Request the given memory area to be located at the given node index. - void request_memory_on_node(size_t start_page, size_t size_in_pages, uint region_index); + // Requests the given memory area to be located at the given node index. + void request_memory_on_node(void* aligned_address, size_t size_in_bytes, uint region_index); // Returns maximum search depth which is used to limit heap region search iterations. // The number of active nodes, page size and heap region size are considered.