Code Review for jdk

Prepared by:mbalao on Fri Feb 28 15:16:36 -03 2020
Workspace:/home/martin/local_lab/dev/openjdk/repositories/public/jdk8u-dev/jdk
Compare against: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk
Compare against version:13861
Summary of changes: 7785 lines changed: 4893 ins; 1124 del; 1768 mod; 18026 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw THIRD_PARTY_README

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
38 lines changed: 38 ins; 0 del; 0 mod; 3247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/mapfiles/libj2pkcs11/mapfile-vers

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
1 line changed: 1 ins; 0 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/P11RSACipher.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
4 lines changed: 0 ins; 0 del; 4 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/SunPKCS11.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
79 lines changed: 73 ins; 1 del; 5 mod; 1442 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
47 lines changed: 37 ins; 2 del; 8 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/CK_RSA_PKCS_PSS_PARAMS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
101 lines changed: 17 ins; 31 del; 53 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/Functions.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
278 lines changed: 264 ins; 3 del; 11 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
82 lines changed: 45 ins; 1 del; 36 mod; 1827 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
622 lines changed: 244 ins; 162 del; 216 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
16 lines changed: 16 ins; 0 del; 0 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_convert.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
936 lines changed: 242 ins; 350 del; 344 mod; 1371 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_crypt.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
113 lines changed: 35 ins; 31 del; 47 mod; 411 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_digest.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
36 lines changed: 8 ins; 11 del; 17 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_general.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
24 lines changed: 22 ins; 0 del; 2 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_keymgmt.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
134 lines changed: 7 ins; 38 del; 89 mod; 1145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_mutex.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
2 lines changed: 0 ins; 0 del; 2 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_sign.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
161 lines changed: 53 ins; 50 del; 58 mod; 566 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/p11_util.c

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
85 lines changed: 18 ins; 3 del; 64 mod; 1078 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/pkcs11.h

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
67 lines changed: 9 ins; 43 del; 15 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/pkcs11f.h

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
152 lines changed: 57 ins; 30 del; 65 mod; 817 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/pkcs11t.h

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
1424 lines changed: 502 ins; 222 del; 700 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
51 lines changed: 14 ins; 15 del; 22 mod; 433 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/security/pkcs11/MessageDigest/ByteBuffers.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
40 lines changed: 23 ins; 7 del; 10 mod; 85 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/security/pkcs11/P11AEADCipher.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
750 lines changed: 750 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/security/pkcs11/P11PSSSignature.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
701 lines changed: 701 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/CK_CCM_PARAMS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/security/pkcs11/wrapper/CK_GCM_PARAMS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/classes/sun/security/util/GCMParameters.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
153 lines changed: 153 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/Test4512704.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/TestCICOWithGCM.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
197 lines changed: 197 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Cipher/TestKATForGCM.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
322 lines changed: 322 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Signature/InitAgainPSS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
132 lines changed: 132 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Signature/SigInteropPSS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Signature/SignatureTestPSS.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/sun/security/pkcs11/Signature/TestDSA2.java

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/share/native/sun/security/pkcs11/wrapper/pkcs-11v2-20a3.h

rev 13862 : 8080462: Update SunPKCS11 provider with PKCS11 v2.40 support
8169925: PKCS #11 Cryptographic Token Interface license
8238898: Missing hash characters for header on license file
Summary: Added support for GCM, PSS, and other mechanisms
Reviewed-by: jnimeh
124 lines changed: 0 ins; 124 del; 0 mod; 0 unchg

This code review page was prepared using /home/martin/local_lab/dev/openjdk/scripts/webrev.ksh (vers 25.16-hg+openjdk.java.net).