--- old/src/hotspot/share/runtime/jniHandles.cpp 2017-11-29 08:31:01.773448947 -0500 +++ new/src/hotspot/share/runtime/jniHandles.cpp 2017-11-29 08:31:01.591552115 -0500 @@ -47,6 +47,7 @@ } else { Thread* thread = Thread::current(); assert(Universe::heap()->is_in_reserved(obj), "sanity check"); + assert(!current_thread_in_native(), "must not be in native"); return thread->active_handles()->allocate_handle(obj); } } @@ -59,6 +60,8 @@ return NULL; // ignore null handles } else { assert(Universe::heap()->is_in_reserved(obj), "sanity check"); + assert(thread->is_Java_thread(), "not a Java thread"); + assert(!current_thread_in_native(), "must not be in native"); return thread->active_handles()->allocate_handle(obj); } } @@ -70,6 +73,7 @@ } else { JavaThread* thread = JavaThread::thread_from_jni_environment(env); assert(Universe::heap()->is_in_reserved(obj), "sanity check"); + assert(!current_thread_in_native(), "must not be in native"); return thread->active_handles()->allocate_handle(obj); } } @@ -77,6 +81,7 @@ jobject JNIHandles::make_global(Handle obj) { assert(!Universe::heap()->is_gc_active(), "can't extend the root set during GC"); + assert(!current_thread_in_native(), "must not be in native"); jobject res = NULL; if (!obj.is_null()) { // ignore null handles @@ -93,6 +98,7 @@ jobject JNIHandles::make_weak_global(Handle obj) { assert(!Universe::heap()->is_gc_active(), "can't extend the root set during GC"); + assert(!current_thread_in_native(), "must not be in native"); jobject res = NULL; if (!obj.is_null()) { // ignore null handles @@ -265,6 +271,13 @@ weak_oops_do(&verify_handle); } +// This method is implemented here to avoid circular includes between +// jniHandles.hpp and thread.hpp. +bool JNIHandles::current_thread_in_native() { + Thread* thread = Thread::current(); + return (thread->is_Java_thread() && + JavaThread::current()->thread_state() == _thread_in_native); +} void jni_handles_init() { --- old/src/hotspot/share/runtime/jniHandles.hpp 2017-11-29 08:31:02.499940466 -0500 +++ new/src/hotspot/share/runtime/jniHandles.hpp 2017-11-29 08:31:02.318745955 -0500 @@ -48,6 +48,10 @@ template inline static oop resolve_impl(jobject handle); template static oop resolve_jweak(jweak handle); + // This method is not inlined in order to avoid circular includes between + // this header file and thread.hpp. + static bool current_thread_in_native(); + public: // Low tag bit in jobject used to distinguish a jweak. jweak is // type equivalent to jobject, but there are places where we need to @@ -230,6 +234,7 @@ template inline oop JNIHandles::resolve_impl(jobject handle) { assert(handle != NULL, "precondition"); + assert(!current_thread_in_native(), "must not be in native"); oop result; if (is_jweak(handle)) { // Unlikely result = resolve_jweak(handle);