Code Review for open

Prepared by:herrick on Fri Apr 3 08:45:30 EDT 2020
Workspace:/cygdrive/c/ade/jdk-jdk/open
Summary of changes: 199 lines changed: 68 ins; 101 del; 30 mod; 2497 unchg
Patch of changes: open.patch
Bug id: JDK-8237490] [macos : Add support notarizing jpackage app-image and dmg
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppImageBuilder.java

95 lines changed: 40 ins; 33 del; 22 mod; 899 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/MacAppStoreBundler.java

43 lines changed: 0 ins; 41 del; 2 mod; 255 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacResources.properties

3 lines changed: 1 ins; 1 del; 1 mod; 89 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacResources_ja.properties

3 lines changed: 1 ins; 1 del; 1 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacResources_zh_CN.properties

3 lines changed: 1 ins; 1 del; 1 mod; 87 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/Arguments.java

3 lines changed: 0 ins; 3 del; 0 mod; 812 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/ValidOptions.java

4 lines changed: 0 ins; 3 del; 1 mod; 142 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/entitlements.plist

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacAppStore.entitlements

8 lines changed: 0 ins; 8 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/MacAppStore_Inherit.entitlements

10 lines changed: 0 ins; 10 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/macosx/base/SigningBase.java

11 lines changed: 9 ins; 0 del; 2 mod; 126 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).