--- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java 2019-03-05 14:53:40.065595600 -0500 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java 2019-03-05 14:53:39.004782000 -0500 @@ -58,7 +58,7 @@ import java.util.stream.Collectors; /** - * StandardBundlerParams + * StandardBundlerParam * * A parameter to a bundler. * @@ -74,13 +74,10 @@ "jdk.jpackage.internal.resources.MainResources"); private static final String JAVABASEJMOD = "java.base.jmod"; - StandardBundlerParam(String name, String description, String id, - Class valueType, + StandardBundlerParam(String id, Class valueType, Function, T> defaultValueFunction, BiFunction, T> stringConverter) { - this.name = name; - this.description = description; this.id = id; this.valueType = valueType; this.defaultValueFunction = defaultValueFunction; @@ -89,8 +86,6 @@ static final StandardBundlerParam APP_RESOURCES = new StandardBundlerParam<>( - I18N.getString("param.app-resources.name"), - I18N.getString("param.app-resource.description"), BundleParams.PARAM_APP_RESOURCES, RelativeFileSet.class, null, // no default. Required parameter @@ -102,8 +97,6 @@ static final StandardBundlerParam> APP_RESOURCES_LIST = new StandardBundlerParam<>( - I18N.getString("param.app-resources-list.name"), - I18N.getString("param.app-resource-list.description"), BundleParams.PARAM_APP_RESOURCES + "List", (Class>) (Object) List.class, // Default is appResources, as a single item list @@ -114,8 +107,6 @@ static final StandardBundlerParam SOURCE_DIR = new StandardBundlerParam<>( - I18N.getString("param.source-dir.name"), - I18N.getString("param.source-dir.description"), Arguments.CLIOptions.INPUT.getId(), String.class, p -> null, @@ -135,8 +126,6 @@ // their own converter static final StandardBundlerParam MAIN_JAR = new StandardBundlerParam<>( - I18N.getString("param.main-jar.name"), - I18N.getString("param.main-jar.description"), Arguments.CLIOptions.MAIN_JAR.getId(), RelativeFileSet.class, params -> { @@ -149,8 +138,6 @@ // TODO: test CLASSPATH jar manifest Attributet static final StandardBundlerParam CLASSPATH = new StandardBundlerParam<>( - I18N.getString("param.classpath.name"), - I18N.getString("param.classpath.description"), "classpath", String.class, params -> { @@ -161,27 +148,12 @@ (s, p) -> s.replace(File.pathSeparator, " ") ); - static final StandardBundlerParam RUNTIME_INSTALLER = - new StandardBundlerParam<>( - "", - "", - Arguments.CLIOptions.RUNTIME_INSTALLER.getId(), - Boolean.class, - params -> false, - // valueOf(null) is false, and we actually do want null - (s, p) -> (s == null || "null".equalsIgnoreCase(s)) ? - true : Boolean.valueOf(s) - ); - - static final StandardBundlerParam MAIN_CLASS = new StandardBundlerParam<>( - I18N.getString("param.main-class.name"), - I18N.getString("param.main-class.description"), Arguments.CLIOptions.APPCLASS.getId(), String.class, params -> { - if (RUNTIME_INSTALLER.fetchFrom(params)) { + if (isRuntimeInstaller(params)) { return null; } extractMainClassInfoFromAppResources(params); @@ -197,8 +169,6 @@ static final StandardBundlerParam APP_NAME = new StandardBundlerParam<>( - I18N.getString("param.app-name.name"), - I18N.getString("param.app-name.description"), Arguments.CLIOptions.NAME.getId(), String.class, params -> { @@ -216,8 +186,6 @@ static final StandardBundlerParam ICON = new StandardBundlerParam<>( - I18N.getString("param.icon-file.name"), - I18N.getString("param.icon-file.description"), Arguments.CLIOptions.ICON.getId(), File.class, params -> null, @@ -226,28 +194,14 @@ static final StandardBundlerParam VENDOR = new StandardBundlerParam<>( - I18N.getString("param.vendor.name"), - I18N.getString("param.vendor.description"), Arguments.CLIOptions.VENDOR.getId(), String.class, params -> I18N.getString("param.vendor.default"), (s, p) -> s ); - static final StandardBundlerParam CATEGORY = - new StandardBundlerParam<>( - I18N.getString("param.category.name"), - I18N.getString("param.category.description"), - Arguments.CLIOptions.CATEGORY.getId(), - String.class, - params -> I18N.getString("param.category.default"), - (s, p) -> s - ); - static final StandardBundlerParam DESCRIPTION = new StandardBundlerParam<>( - I18N.getString("param.description.name"), - I18N.getString("param.description.description"), Arguments.CLIOptions.DESCRIPTION.getId(), String.class, params -> params.containsKey(APP_NAME.getID()) @@ -258,8 +212,6 @@ static final StandardBundlerParam COPYRIGHT = new StandardBundlerParam<>( - I18N.getString("param.copyright.name"), - I18N.getString("param.copyright.description"), Arguments.CLIOptions.COPYRIGHT.getId(), String.class, params -> MessageFormat.format(I18N.getString( @@ -270,8 +222,6 @@ @SuppressWarnings("unchecked") static final StandardBundlerParam> ARGUMENTS = new StandardBundlerParam<>( - I18N.getString("param.arguments.name"), - I18N.getString("param.arguments.description"), Arguments.CLIOptions.ARGUMENTS.getId(), (Class>) (Object) List.class, params -> Collections.emptyList(), @@ -281,8 +231,6 @@ @SuppressWarnings("unchecked") static final StandardBundlerParam> JVM_OPTIONS = new StandardBundlerParam<>( - I18N.getString("param.jvm-options.name"), - I18N.getString("param.jvm-options.description"), Arguments.CLIOptions.JVM_ARGS.getId(), (Class>) (Object) List.class, params -> Collections.emptyList(), @@ -291,8 +239,6 @@ static final StandardBundlerParam TITLE = new StandardBundlerParam<>( - I18N.getString("param.title.name"), - I18N.getString("param.title.description"), BundleParams.PARAM_TITLE, String.class, APP_NAME::fetchFrom, @@ -303,8 +249,6 @@ // their own converter static final StandardBundlerParam VERSION = new StandardBundlerParam<>( - I18N.getString("param.version.name"), - I18N.getString("param.version.description"), Arguments.CLIOptions.VERSION.getId(), String.class, params -> I18N.getString("param.version.default"), @@ -314,19 +258,15 @@ @SuppressWarnings("unchecked") public static final StandardBundlerParam LICENSE_FILE = new StandardBundlerParam<>( - I18N.getString("param.license-file.name"), - I18N.getString("param.license-file.description"), Arguments.CLIOptions.LICENSE_FILE.getId(), String.class, params -> null, (s, p) -> s ); - static final StandardBundlerParam BUILD_ROOT = + static final StandardBundlerParam TEMP_ROOT = new StandardBundlerParam<>( - I18N.getString("param.build-root.name"), - I18N.getString("param.build-root.description"), - Arguments.CLIOptions.BUILD_ROOT.getId(), + Arguments.CLIOptions.TEMP_ROOT.getId(), File.class, params -> { try { @@ -341,13 +281,11 @@ public static final StandardBundlerParam CONFIG_ROOT = new StandardBundlerParam<>( - I18N.getString("param.config-root.name"), - I18N.getString("param.config-root.description"), "configRoot", File.class, params -> { File root = - new File(BUILD_ROOT.fetchFrom(params), "config"); + new File(TEMP_ROOT.fetchFrom(params), "config"); root.mkdirs(); return root; }, @@ -356,8 +294,6 @@ static final StandardBundlerParam IDENTIFIER = new StandardBundlerParam<>( - I18N.getString("param.identifier.name"), - I18N.getString("param.identifier.description"), Arguments.CLIOptions.IDENTIFIER.getId(), String.class, params -> { @@ -375,8 +311,6 @@ static final StandardBundlerParam PREFERENCES_ID = new StandardBundlerParam<>( - I18N.getString("param.preferences-id.name"), - I18N.getString("param.preferences-id.description"), "preferencesID", String.class, p -> Optional.ofNullable(IDENTIFIER.fetchFrom(p)). @@ -386,8 +320,6 @@ static final StandardBundlerParam VERBOSE = new StandardBundlerParam<>( - I18N.getString("param.verbose.name"), - I18N.getString("param.verbose.description"), Arguments.CLIOptions.VERBOSE.getId(), Boolean.class, params -> false, @@ -396,22 +328,8 @@ true : Boolean.valueOf(s) ); - static final StandardBundlerParam OVERWRITE = - new StandardBundlerParam<>( - I18N.getString("param.overwrite.name"), - I18N.getString("param.overwrite.description"), - Arguments.CLIOptions.OVERWRITE.getId(), - Boolean.class, - params -> false, - // valueOf(null) is false, and we actually do want null - (s, p) -> (s == null || "null".equalsIgnoreCase(s)) ? - true : Boolean.valueOf(s) - ); - static final StandardBundlerParam RESOURCE_DIR = new StandardBundlerParam<>( - I18N.getString("param.resource-dir.name"), - I18N.getString("param.resource-dir.description"), Arguments.CLIOptions.RESOURCE_DIR.getId(), File.class, params -> null, @@ -420,8 +338,6 @@ static final BundlerParamInfo INSTALL_DIR = new StandardBundlerParam<>( - I18N.getString("param.install-dir.name"), - I18N.getString("param.install-dir.description"), Arguments.CLIOptions.INSTALL_DIR.getId(), String.class, params -> null, @@ -430,8 +346,6 @@ static final StandardBundlerParam PREDEFINED_APP_IMAGE = new StandardBundlerParam<>( - I18N.getString("param.predefined-app-image.name"), - I18N.getString("param.predefined-app-image.description"), Arguments.CLIOptions.PREDEFINED_APP_IMAGE.getId(), File.class, params -> null, @@ -439,19 +353,15 @@ static final StandardBundlerParam PREDEFINED_RUNTIME_IMAGE = new StandardBundlerParam<>( - I18N.getString("param.predefined-runtime-image.name"), - I18N.getString("param.predefined-runtime-image.description"), Arguments.CLIOptions.PREDEFINED_RUNTIME_IMAGE.getId(), File.class, params -> null, (s, p) -> new File(s)); @SuppressWarnings("unchecked") - static final StandardBundlerParam>> SECONDARY_LAUNCHERS = + static final StandardBundlerParam>> ADD_LAUNCHERS = new StandardBundlerParam<>( - I18N.getString("param.secondary-launchers.name"), - I18N.getString("param.secondary-launchers.description"), - Arguments.CLIOptions.SECONDARY_LAUNCHER.getId(), + Arguments.CLIOptions.ADD_LAUNCHER.getId(), (Class>>) (Object) List.class, params -> new ArrayList<>(1), @@ -463,8 +373,6 @@ static final StandardBundlerParam >> FILE_ASSOCIATIONS = new StandardBundlerParam<>( - I18N.getString("param.file-associations.name"), - I18N.getString("param.file-associations.description"), Arguments.CLIOptions.FILE_ASSOCIATIONS.getId(), (Class>>) (Object) List.class, @@ -476,8 +384,6 @@ @SuppressWarnings("unchecked") static final StandardBundlerParam> FA_EXTENSIONS = new StandardBundlerParam<>( - I18N.getString("param.fa-extension.name"), - I18N.getString("param.fa-extension.description"), "fileAssociation.extension", (Class>) (Object) List.class, params -> null, // null means not matched to an extension @@ -487,8 +393,6 @@ @SuppressWarnings("unchecked") static final StandardBundlerParam> FA_CONTENT_TYPE = new StandardBundlerParam<>( - I18N.getString("param.fa-content-type.name"), - I18N.getString("param.fa-content-type.description"), "fileAssociation.contentType", (Class>) (Object) List.class, params -> null, @@ -498,8 +402,6 @@ static final StandardBundlerParam FA_DESCRIPTION = new StandardBundlerParam<>( - I18N.getString("param.fa-description.name"), - I18N.getString("param.fa-description.description"), "fileAssociation.description", String.class, params -> APP_NAME.fetchFrom(params) + " File", @@ -508,8 +410,6 @@ static final StandardBundlerParam FA_ICON = new StandardBundlerParam<>( - I18N.getString("param.fa-icon.name"), - I18N.getString("param.fa-icon.description"), "fileAssociation.icon", File.class, ICON::fetchFrom, @@ -519,8 +419,6 @@ @SuppressWarnings("unchecked") static final BundlerParamInfo> MODULE_PATH = new StandardBundlerParam<>( - I18N.getString("param.module-path.name"), - I18N.getString("param.module-path.description"), Arguments.CLIOptions.MODULE_PATH.getId(), (Class>) (Object)List.class, p -> { return getDefaultModulePath(); }, @@ -560,8 +458,6 @@ static final BundlerParamInfo MODULE = new StandardBundlerParam<>( - I18N.getString("param.main.module.name"), - I18N.getString("param.main.module.description"), Arguments.CLIOptions.MODULE.getId(), String.class, p -> null, @@ -572,8 +468,6 @@ @SuppressWarnings("unchecked") static final BundlerParamInfo> ADD_MODULES = new StandardBundlerParam<>( - I18N.getString("param.add-modules.name"), - I18N.getString("param.add-modules.description"), Arguments.CLIOptions.ADD_MODULES.getId(), (Class>) (Object) Set.class, p -> new LinkedHashSet(), @@ -583,23 +477,22 @@ @SuppressWarnings("unchecked") static final BundlerParamInfo> LIMIT_MODULES = new StandardBundlerParam<>( - I18N.getString("param.limit-modules.name"), - I18N.getString("param.limit-modules.description"), "limit-modules", (Class>) (Object) Set.class, p -> new LinkedHashSet(), (s, p) -> new LinkedHashSet<>(Arrays.asList(s.split(","))) ); - static final BundlerParamInfo STRIP_NATIVE_COMMANDS = - new StandardBundlerParam<>( - I18N.getString("param.strip-executables.name"), - I18N.getString("param.strip-executables.description"), - Arguments.CLIOptions.STRIP_NATIVE_COMMANDS.getId(), - Boolean.class, - p -> Boolean.FALSE, - (s, p) -> Boolean.valueOf(s) - ); + static boolean isRuntimeInstaller(Map p) { + if (p.containsKey(MODULE.getID()) || + p.containsKey(MAIN_JAR.getID()) || + p.containsKey(PREDEFINED_APP_IMAGE.getID())) { + return false; // we are building or are given an application + } + // runtime installer requires --runtime-image, if this is false + // here then we should have thrown error validating args. + return p.containsKey(PREDEFINED_RUNTIME_IMAGE.getID()); + } static File getPredefinedAppImage(Map p) { File applicationImage = null; @@ -660,11 +553,9 @@ boolean hasMainJar = params.containsKey(MAIN_JAR.getID()); boolean hasMainJarClassPath = params.containsKey(CLASSPATH.getID()); boolean hasModule = params.containsKey(MODULE.getID()); - boolean runtimeInstaller = - params.containsKey(RUNTIME_INSTALLER.getID()); if (hasMainClass && hasMainJar && hasMainJarClassPath || hasModule || - runtimeInstaller) { + isRuntimeInstaller(params)) { return; } @@ -748,11 +639,9 @@ boolean hasMainJarClassPath = params.containsKey(CLASSPATH.getID()); boolean hasModule = params.containsKey(MODULE.getID()); boolean hasAppImage = params.containsKey(PREDEFINED_APP_IMAGE.getID()); - boolean runtimeInstaller = - params.containsKey(RUNTIME_INSTALLER.getID()); if (hasMainClass && hasMainJar && hasMainJarClassPath || - hasModule || runtimeInstaller || hasAppImage) { + hasModule || hasAppImage || isRuntimeInstaller(params)) { return; } @@ -775,7 +664,6 @@ } } - private static List splitStringWithEscapes(String s) { List l = new ArrayList<>(); StringBuilder current = new StringBuilder();