--- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java 2019-03-05 14:53:23.794587000 -0500 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java 2019-03-05 14:53:22.780574000 -0500 @@ -57,7 +57,6 @@ String vendor; String email; String description; - String category; String licenseType; String copyright; String version; @@ -74,7 +73,6 @@ // Java 9 modules support String addModules = null; String limitModules = null; - Boolean stripNativeCommands = null; String modulePath = null; String module = null; String debugPort = null; @@ -90,10 +88,6 @@ // raw arguments to the bundler Map bundlerArguments = new LinkedHashMap<>(); - void setCategory(String category) { - this.category = category; - } - void setLicenseType(String licenseType) { this.licenseType = licenseType; } @@ -168,10 +162,6 @@ this.debugPort = value; } - void setStripNativeCommands(boolean value) { - this.stripNativeCommands = value; - } - void setDescription(String description) { this.description = description; } @@ -339,7 +329,7 @@ boolean hasModule = (bundlerArguments.get( Arguments.CLIOptions.MODULE.getId()) != null); - boolean hasImage = (bundlerArguments.get( + boolean hasAppImage = (bundlerArguments.get( Arguments.CLIOptions.PREDEFINED_APP_IMAGE.getId()) != null); boolean hasClass = (bundlerArguments.get( Arguments.CLIOptions.APPCLASS.getId()) != null); @@ -351,10 +341,8 @@ Arguments.CLIOptions.INPUT.getId()) != null); boolean hasModulePath = (bundlerArguments.get( Arguments.CLIOptions.MODULE_PATH.getId()) != null); - boolean hasAppImage = (bundlerArguments.get( - Arguments.CLIOptions.PREDEFINED_APP_IMAGE.getId()) != null); - boolean runtimeInstaller = (bundlerArguments.get( - Arguments.CLIOptions.RUNTIME_INSTALLER.getId()) != null); + boolean runtimeInstaller = (BundlerType.INSTALLER == getBundleType()) && + !hasAppImage && !hasModule && !hasMain && hasRuntimeImage; if (getBundleType() == BundlerType.IMAGE) { // Module application requires --runtime-image or --module-path @@ -387,7 +375,7 @@ // if bundling non-modular image, or installer without app-image // then we need some resources and a main class - if (!hasModule && !hasImage && !runtimeInstaller) { + if (!hasModule && !hasAppImage && !runtimeInstaller) { if (resources.isEmpty()) { throw new PackagerException("ERR_MissingAppResources"); } @@ -415,9 +403,9 @@ } } - // Validate build-root + // Validate temp-root String root = (String)bundlerArguments.get( - Arguments.CLIOptions.BUILD_ROOT.getId()); + Arguments.CLIOptions.TEMP_ROOT.getId()); if (root != null) { String [] contents = (new File(root)).list(); @@ -527,7 +515,6 @@ bundleParams.setEmail(email); bundleParams.setInstalldirChooser(installdirChooser); bundleParams.setCopyright(copyright); - bundleParams.setApplicationCategory(category); bundleParams.setDescription(description); bundleParams.setTitle(title); @@ -542,10 +529,6 @@ bundleParams.setLimitModules(limitModules); } - if (stripNativeCommands != null) { - bundleParams.setStripNativeCommands(stripNativeCommands); - } - if (modulePath != null && !modulePath.isEmpty()) { bundleParams.setModulePath(modulePath); }