Code Review for open

Prepared by:herrick on Mon Mar 4 08:10:42 EST 2019
Workspace:/home/aherrick/sandbox/open
Branch:JDK-8200758-branch
Summary of changes: 2593 lines changed: 595 ins; 1735 del; 263 mod; 12668 unchg
Patch of changes: open.patch
Bug id: JDK-8219678 : CLI changes in jpackage
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppBundler.java

31 lines changed: 0 ins; 28 del; 3 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java

4 lines changed: 0 ins; 2 del; 2 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java

39 lines changed: 0 ins; 20 del; 19 mod; 855 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

29 lines changed: 0 ins; 10 del; 19 mod; 699 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties

37 lines changed: 0 ins; 37 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_ja.properties

37 lines changed: 0 ins; 37 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_zh_CN.properties

37 lines changed: 0 ins; 37 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.postinst

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.prerm

1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec

2 lines changed: 0 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppBundler.java

41 lines changed: 0 ins; 38 del; 3 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java

25 lines changed: 0 ins; 16 del; 9 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java

9 lines changed: 0 ins; 8 del; 1 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java

13 lines changed: 0 ins; 10 del; 3 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java

4 lines changed: 0 ins; 2 del; 2 mod; 481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgBundler.java

11 lines changed: 0 ins; 10 del; 1 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_ja.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractBundler.java

4 lines changed: 0 ins; 2 del; 2 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractImageBundler.java

23 lines changed: 1 ins; 18 del; 4 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

72 lines changed: 27 ins; 21 del; 24 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundleParams.java

5 lines changed: 0 ins; 5 del; 0 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java

27 lines changed: 2 ins; 25 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java

17 lines changed: 0 ins; 11 del; 6 mod; 596 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/EnumeratedBundlerParam.java

17 lines changed: 0 ins; 17 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java

59 lines changed: 12 ins; 38 del; 9 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java

125 lines changed: 1 ins; 105 del; 19 mod; 778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java

125 lines changed: 11 ins; 49 del; 65 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties

103 lines changed: 6 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_ja.properties

103 lines changed: 6 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties

103 lines changed: 6 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java

28 lines changed: 0 ins; 25 del; 3 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

38 lines changed: 0 ins; 19 del; 19 mod; 855 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

46 lines changed: 0 ins; 22 del; 24 mod; 1118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java

9 lines changed: 0 ins; 6 del; 3 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsBundlerParam.java

14 lines changed: 0 ins; 12 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties

42 lines changed: 0 ins; 42 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties

42 lines changed: 0 ins; 42 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties

42 lines changed: 0 ins; 42 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.iss

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.wxs

1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java

167 lines changed: 167 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherBase.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherModuleTest.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherTest.java

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageTempRootTest.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/share/classes/jdk/jpackage/internal/SecondaryLauncherArguments.java

164 lines changed: 0 ins; 164 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageBuildRootTest.java

109 lines changed: 0 ins; 109 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherBase.java

141 lines changed: 0 ins; 141 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherModuleTest.java

52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherTest.java

54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).