Code Review for jdk

Prepared by:darcy on Wed Dec 5 13:52:45 PST 2018
Workspace:/home/darcy/JDK/Scm/hg/jdk
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 182 lines changed: 43 ins; 0 del; 139 mod; 24080 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/autoconf/version-numbers

4 lines changed: 0 ins; 0 del; 4 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/SetupJavaCompilers.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

2 lines changed: 2 ins; 0 del; 0 mod; 6419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/java/util/jar/pack/Constants.java

5 lines changed: 4 ins; 0 del; 1 mod; 506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/ModuleInfo.java

1 line changed: 0 ins; 0 del; 1 mod; 1101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

1 line changed: 0 ins; 0 del; 1 mod; 3633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java

1 line changed: 1 ins; 0 del; 0 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/SourceVersion.java

13 lines changed: 11 ins; 0 del; 2 mod; 411 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/ElementScanner9.java

2 lines changed: 0 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor9.java

2 lines changed: 0 ins; 0 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java

11 lines changed: 6 ins; 0 del; 5 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java

2 lines changed: 1 ins; 0 del; 1 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Profile.java

3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java

4 lines changed: 3 ins; 0 del; 1 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java

1 line changed: 0 ins; 0 del; 1 mod; 644 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/Classfile.java

1 line changed: 0 ins; 0 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 721 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.rmic/share/classes/sun/tools/java/RuntimeConstants.java

1 line changed: 0 ins; 0 del; 1 mod; 741 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jaxp/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/module/ClassFileVersionsTest.java

6 lines changed: 5 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6330997/T6330997.java

2 lines changed: 0 ins; 0 del; 2 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/ConditionalWithVoid.java

1 line changed: 0 ins; 0 del; 1 mod; 19 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/RawStringLiteralLang.java

1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/RawStringLiteralLangAPI.java

3 lines changed: 0 ins; 0 del; 3 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/api/T6395981.java

2 lines changed: 0 ins; 0 del; 2 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/ClassVersionChecker.java

2 lines changed: 1 ins; 0 del; 1 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakAmbiguousTarget.java

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakExprNotImmediate.java

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakMissingValue.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/BreakOutsideSwitchExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/ContinueOutsideSwitchExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/IncompatibleTypesInSwitchExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/MultipleCaseLabels.java

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/NotExhaustive.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFeatureUse.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFilename.java

1 line changed: 0 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewFilenameAdditional.java

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/PreviewPlural/PreviewPlural.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/RawStringLiteral.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/ReturnOutsideSwitchExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/RuleCompletesNormally.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchCaseUnexpectedStatement.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionCompletesNormally.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionEmpty.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressionTargetCantBeVoid.java

1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchExpressions.java

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchMixingCaseTypes.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/diags/examples/SwitchRules.java

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/expswitch/ExpSwitchNestingTest.java

5 lines changed: 2 ins; 0 del; 3 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lambda/BadSwitchExpressionLambda.java

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/lib/JavacTestingAbstractProcessor.java

9 lines changed: 0 ins; 0 del; 9 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/parser/JavacParserTest.java

1 line changed: 0 ins; 0 del; 1 mod; 1379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/preview/classReaderTest/Client.java

2 lines changed: 0 ins; 0 del; 2 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/preview/classReaderTest/Client.nopreview.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/preview/classReaderTest/Client.preview.out

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/profiles/ProfileOptionTest.java

1 line changed: 1 ins; 0 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BlockExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BooleanNumericNonNumeric.java

1 line changed: 0 ins; 0 del; 1 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/BreakTest.java

1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/CRT.java

1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java

1 line changed: 0 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/DefiniteAssignment2.java

1 line changed: 0 ins; 0 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/EmptySwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExhaustiveEnumSwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks1.java

1 line changed: 0 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks2.java

1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBugs.java

1 line changed: 0 ins; 0 del; 1 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchBugsInGen.java

1 line changed: 0 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchCodeFromJLS.java

1 line changed: 0 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchDA.java

1 line changed: 0 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchEmbedding.java

1 line changed: 0 ins; 0 del; 1 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough.java

1 line changed: 0 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough1.java

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchFlow.java

1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchInExpressionSwitch.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchIntersectionTypes.java

1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchNotExhaustive.java

1 line changed: 0 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ExpressionSwitchUnreachable.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ParseIncomplete.java

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/ParserRecovery.java

1 line changed: 0 ins; 0 del; 1 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionIsNotAConstant.java

1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionScopesIsolated.java

1 line changed: 0 ins; 0 del; 1 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchexpr/SwitchExpressionSimpleVisitorTest.java

1 line changed: 0 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/CaseTest.java

1 line changed: 0 ins; 0 del; 1 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/MultipleLabelsExpression.java

1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/MultipleLabelsStatement.java

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/RuleParsingTest.java

1 line changed: 0 ins; 0 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchArrowBrokenConstant.java

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementArrow.java

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementBroken.java

1 line changed: 0 ins; 0 del; 1 mod; 20 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementBroken2.java

1 line changed: 0 ins; 0 del; 1 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/switchextra/SwitchStatementScopesIsolated.java

1 line changed: 0 ins; 0 del; 1 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/versions/Versions.java

9 lines changed: 6 ins; 0 del; 3 mod; 474 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/nashorn/TEST.ROOT

1 line changed: 0 ins; 0 del; 1 mod; 16 unchg

This code review page was prepared using /home/darcy/JDK/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).