Code Review for hs25.60-b11-jdk8u60-b11

Prepared by:amurillo on Fri Apr 10 10:10:10 PDT 2015
Workspace:hs25.60-b11-jdk8u60-b11
Compare against: jdk8u/jdk8u
Summary of changes: 622 lines changed: 376 ins; 69 del; 177 mod; 45638 unchg
Patch of changes: hs25.60-b11-jdk8u60-b11.patch
Author comments:
8044416: serviceability/sa/jmap-hashcode/Test8028623.java fails with AssertionFailure: can not get class data for java/lang/UNIXProcess$Platform$$Lambda
8044531: Event based tracing locks to rank as leafs where possible
8057037: Verification in ClassLoaderData::is_alive is too slow
8065331: Add trace events for failed allocations
8066679: jvmtiRedefineClasses.cpp assert cache ptrs must match
8066771: Refactor VM GC operations caused by allocation failure
8067235: embedded/minvm/checknmt fails on compact1 and compact2 with minimal VM
8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
8067991: [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect
8069263: assert(fm == NULL || fm->method_holder() == _participants[n]) failed: sanity
8072621: Clean up around VM_GC_Operations
8075587: Compilation of constant array containing different sub classes crashes the JVM
8076760: new hotspot build - hs25.60-b11
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktrace.sh

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
2 lines changed: 0 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceApp.java

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
53 lines changed: 47 ins; 1 del; 5 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceTarget.java

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
10 lines changed: 9 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceTargetB.java

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
13 lines changed: 12 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceTargetB_2.java

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
4 lines changed: 3 ins; 0 del; 1 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw jdk/test/java/lang/instrument/RedefineMethodInBacktraceTarget_2.java

rev 10589 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: update java/lang/instrument/RedefineMethodInBacktrace.sh test to cover the hotspot fix
Reviewed-by: coleenp, dcubed
5 lines changed: 4 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 7220 : Added tag hs25.60-b11 for changeset 64a32bc18e88
1 line changed: 1 ins; 0 del; 0 mod; 612 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/agent/src/share/classes/com/sun/java/swing/ui/CommonToolBar.java

rev 7205 : 8067991: [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect
Summary: Fixed java programmint style nit
Reviewed-by: jbachorik, sspitsyn
1 line changed: 0 ins; 0 del; 1 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/agent/src/share/classes/com/sun/java/swing/ui/CommonUI.java

rev 7205 : 8067991: [Findbugs] SA com.sun.java.swing.ui.CommonUI some methods need final protect
Summary: Fixed java programmint style nit
Reviewed-by: jbachorik, sspitsyn
20 lines changed: 5 ins; 0 del; 15 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java

rev 7218 : 8044416: serviceability/sa/jmap-hashcode/Test8028623.java fails with AssertionFailure: can not get class data for java/lang/UNIXProcess$Platform$$Lambda
Summary: Lambda object is not counted when SA builds class data cache but is reached inside live region.
Reviewed-by: sla, jbachorik
13 lines changed: 12 ins; 0 del; 1 mod; 1104 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 7204 : 8076760: new hotspot build - hs25.60-b11
Reviewed-by: dholmes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/classLoaderData.cpp

rev 7206 : 8057037: Verification in ClassLoaderData::is_alive is too slow
Reviewed-by: brutisso, mgerdin, tschatzl
30 lines changed: 0 ins; 30 del; 0 mod; 956 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/javaClasses.cpp

rev 7207 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: use method cpref and klass version to provide meaningful methods name in stacktraces
Reviewed-by: coleenp, dcubed
68 lines changed: 32 ins; 12 del; 24 mod; 3556 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/javaClasses.hpp

rev 7207 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: use method cpref and klass version to provide meaningful methods name in stacktraces
Reviewed-by: coleenp, dcubed
7 lines changed: 1 ins; 0 del; 6 mod; 1443 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/code/dependencies.cpp

rev 7214 : 8069263: assert(fm == NULL || fm->method_holder() == _participants[n]) failed: sanity
Summary: default methods added to classes confuse dependency processing
Reviewed-by: kvn
7 lines changed: 6 ins; 0 del; 1 mod; 1690 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
3 lines changed: 0 ins; 0 del; 3 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
19 lines changed: 0 ins; 0 del; 19 mod; 6886 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
12 lines changed: 0 ins; 0 del; 12 mod; 1624 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
3 lines changed: 0 ins; 0 del; 3 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/g1/vm_operations_g1.cpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
13 lines changed: 0 ins; 2 del; 11 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/g1/vm_operations_g1.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
14 lines changed: 0 ins; 3 del; 11 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
4 lines changed: 0 ins; 0 del; 4 mod; 734 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
10 lines changed: 0 ins; 2 del; 8 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
11 lines changed: 0 ins; 7 del; 4 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/shared/vmGCOperations.cpp

rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
rev 7212 : 8065331: Add trace events for failed allocations
Reviewed-by: ehelin, jwilhelm
23 lines changed: 20 ins; 0 del; 3 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_implementation/shared/vmGCOperations.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
rev 7211 : 8066771: Refactor VM GC operations caused by allocation failure
Reviewed-by: brutisso, jmasa
rev 7212 : 8065331: Add trace events for failed allocations
Reviewed-by: ehelin, jwilhelm
47 lines changed: 17 ins; 10 del; 20 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_interface/allocTracer.cpp

rev 7212 : 8065331: Add trace events for failed allocations
Reviewed-by: ehelin, jwilhelm
11 lines changed: 10 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/gc_interface/allocTracer.hpp

rev 7212 : 8065331: Add trace events for failed allocations
Reviewed-by: ehelin, jwilhelm
2 lines changed: 1 ins; 0 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/memory/collectorPolicy.cpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
3 lines changed: 0 ins; 0 del; 3 mod; 1097 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.cpp

rev 7207 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: use method cpref and klass version to provide meaningful methods name in stacktraces
Reviewed-by: coleenp, dcubed
47 lines changed: 47 ins; 0 del; 0 mod; 3832 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.hpp

rev 7207 : 8067662: "java.lang.NullPointerException: Method name is null" from StackTraceElement.<init>
Summary: use method cpref and klass version to provide meaningful methods name in stacktraces
Reviewed-by: coleenp, dcubed
3 lines changed: 3 ins; 0 del; 0 mod; 1352 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/type.cpp

rev 7217 : 8075587: Compilation of constant array containing different sub classes crashes the JVM
Summary: meet of 2 constant arrays result in bottom
Reviewed-by: kvn
3 lines changed: 2 ins; 0 del; 1 mod; 4973 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/prims/jvmtiRedefineClasses.cpp

rev 7216 : 8066679: jvmtiRedefineClasses.cpp assert cache ptrs must match
Summary: remove the assert and deallocate cashed class file bytes that are in collision
Reviewed-by: coleenp, dcubed
7 lines changed: 0 ins; 1 del; 6 mod; 4237 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/arguments.cpp

rev 7208 : 8067235: embedded/minvm/checknmt fails on compact1 and compact2 with minimal VM
Reviewed-by: lfoltan, sspitsyn
7 lines changed: 5 ins; 1 del; 1 mod; 4306 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/globals.hpp

rev 7210 : 8072621: Clean up around VM_GC_Operations
Reviewed-by: brutisso, jmasa
1 line changed: 0 ins; 0 del; 1 mod; 4003 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/mutexLocker.cpp

rev 7213 : 8044531: Event based tracing locks to rank as leafs where possible
Reviewed-by: dcubed, dholmes
4 lines changed: 0 ins; 0 del; 4 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/trace/trace.xml

rev 7212 : 8065331: Add trace events for failed allocations
Reviewed-by: ehelin, jwilhelm
7 lines changed: 6 ins; 0 del; 1 mod; 436 unchg

------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/inlining/DefaultMethodsDependencies.java

rev 7214 : 8069263: assert(fm == NULL || fm->method_holder() == _participants[n]) failed: sanity
Summary: default methods added to classes confuse dependency processing
Reviewed-by: kvn
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/types/TestMeetExactConstantArrays.java

rev 7217 : 8075587: Compilation of constant array containing different sub classes crashes the JVM
Summary: meet of 2 constant arrays result in bottom
Reviewed-by: kvn
70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).