Code Review for hs25.60-b08-jdk8u60-b08

Prepared by:amurillo on Fri Mar 20 09:31:46 PDT 2015
Workspace:hs25.60-b08-jdk8u60-b08
Compare against: jdk8u/jdk8u
Summary of changes: 692 lines changed: 361 ins; 215 del; 116 mod; 83254 unchg
Patch of changes: hs25.60-b08-jdk8u60-b08.patch
Author comments:
8027914: Client JVM silently exit with fail exit code when running in compact(1,2) with options -Dcom.sun.management and -XX:+ManagementServer
8042796: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
8074869: C2 code generator can replace -0.0f with +0.0f on Linux
8075144: new hotspot build - hs25.60-b08
8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)
Legend: Modified file
Deleted file
New file

------ ------ ------ ------ --- New ----- Raw jdk/test/java/lang/instrument/ManyMethodsBenchmarkAgent.java

rev 10539 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: add new test java/lang/instrument/ManyMethodsBenchmarkAgent.java
Reviewed-by: coleenp, dcubed
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw jdk/test/java/lang/instrument/ManyMethodsBenchmarkApp.java

rev 10539 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: add new test java/lang/instrument/ManyMethodsBenchmarkAgent.java
Reviewed-by: coleenp, dcubed
141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 7164 : Added tag hs25.60-b08 for changeset a72a4192a36d
1 line changed: 1 ins; 0 del; 0 mod; 606 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/make/bsd/makefiles/gcc.make

rev 7161 : 8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)
Reviewed-by: dholmes, erikj
1 line changed: 0 ins; 0 del; 1 mod; 483 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/make/bsd/makefiles/saproc.make

rev 7161 : 8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)
Reviewed-by: dholmes, erikj
3 lines changed: 3 ins; 0 del; 0 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 7155 : 8075144: new hotspot build - hs25.60-b08
Reviewed-by: dholmes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/ppc.ad

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
4 lines changed: 1 ins; 1 del; 2 mod; 12124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/sparc/vm/sparc.ad

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
9 lines changed: 1 ins; 5 del; 3 mod; 11048 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/aix/vm/os_aix.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
5 lines changed: 0 ins; 5 del; 0 mod; 5241 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/bsd/vm/os_bsd.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
3 lines changed: 0 ins; 3 del; 0 mod; 4827 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/linux/vm/os_linux.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
117 lines changed: 0 ins; 117 del; 0 mod; 6206 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/solaris/vm/os_solaris.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
4 lines changed: 0 ins; 4 del; 0 mod; 6489 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/windows/vm/os_windows.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
4 lines changed: 0 ins; 4 del; 0 mod; 5809 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/defaultMethods.cpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 1119 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/constMethod.hpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
5 lines changed: 4 ins; 0 del; 1 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/cpCache.cpp

rev 7159 : 8042796: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
Summary: Relax the guaranty for deleted methods
Reviewed-by: dcubed, coleenp
rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
42 lines changed: 24 ins; 5 del; 13 mod; 674 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/cpCache.hpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
5 lines changed: 1 ins; 0 del; 4 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.cpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
26 lines changed: 4 ins; 1 del; 21 mod; 3807 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.hpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
3 lines changed: 0 ins; 1 del; 2 mod; 1350 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/klassVtable.cpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
89 lines changed: 20 ins; 23 del; 46 mod; 1476 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/klassVtable.hpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
5 lines changed: 0 ins; 2 del; 3 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/method.cpp

rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
2 lines changed: 1 ins; 0 del; 1 mod; 2043 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/method.hpp

rev 7159 : 8042796: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
Summary: Relax the guaranty for deleted methods
Reviewed-by: dcubed, coleenp
rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
6 lines changed: 5 ins; 0 del; 1 mod; 1075 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/prims/jvmtiRedefineClasses.cpp

rev 7159 : 8042796: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
Summary: Relax the guaranty for deleted methods
Reviewed-by: dcubed, coleenp
rev 7160 : 8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
Summary: optimize the adjust_method_entries functions by using the orig_method_idnum() function
Reviewed-by: coleenp, dcubed
33 lines changed: 10 ins; 12 del; 11 mod; 4223 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/globals.hpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
3 lines changed: 0 ins; 3 del; 0 mod; 4004 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/os.hpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
1 line changed: 0 ins; 1 del; 0 mod; 994 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/thread.cpp

rev 7157 : 8043770: File leak in MemNotifyThread::start() in hotspot.src.os.linux.vm.os_linux.cpp
Summary: Fixed by removing all code related to LowMemoryProtection, which removed offending code.
Reviewed-by: dholmes, minqi
3 lines changed: 0 ins; 3 del; 0 mod; 4676 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/services/management.cpp

rev 7156 : 8027914: Client JVM silently exit with fail exit code when running in compact(1,2) with options -Dcom.sun.management and -XX:+ManagementServer
Summary: Check for sun.management.Agent class and print message and exit VM if not found at startup.
Reviewed-by: dholmes, mchung
6 lines changed: 3 ins; 0 del; 3 mod; 2367 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/utilities/accessFlags.hpp

rev 7159 : 8042796: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
Summary: Relax the guaranty for deleted methods
Reviewed-by: dcubed, coleenp
5 lines changed: 3 ins; 0 del; 2 mod; 261 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
8 lines changed: 0 ins; 8 del; 0 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/utilities/globalDefinitions_sparcWorks.hpp

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
9 lines changed: 0 ins; 9 del; 0 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/utilities/globalDefinitions_xlc.hpp

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
8 lines changed: 0 ins; 8 del; 0 mod; 184 unchg

------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/loopopts/ConstFPVectorization.java

rev 7162 : 8074869: C2 code generator can replace -0.0f with +0.0f on Linux
Summary: Instead of 'fpclass', use cast float->int and double->long to check if value is +0.0f and +0.0d, respectively.
Reviewed-by: kvn, simonis, dlong
63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).