Code Review for hs25.40-b23-jdk8u40-b19

Prepared by:amurillo on Fri Dec 12 10:54:40 PST 2014
Workspace:hs25.40-b23-jdk8u40-b19
Compare against: jdk8u/jdk8u
Summary of changes: 2078 lines changed: 1765 ins; 102 del; 211 mod; 66489 unchg
Patch of changes: hs25.40-b23-jdk8u40-b19.patch
Author comments:
6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
8065634: Crash in InstanceKlass::clean_method_data when _method is NULL
8066103: C2's range check smearing allows out of bound array accesses
8066647: new hotspot build - hs25.40-b23
8066670: PrintSharedArchiveAndExit does not exit the VM when the archive is invalid
8066775: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
8066900: Array Out Of Bounds Exception causes variable corruption
8066964: ppc64: argument and return type profiling, fix problem with popframe
8067144: SIGSEGV with +TraceDeoptimization in Deoptimization::print_objects
8067232: [TESTBUG] runtime/CheckEndorsedAndExtDirs/EndorsedExtDirs.java fails with ClassNotFoundException
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 6964 : Added tag hs25.40-b23 for changeset f8fc5cbe082c
1 line changed: 1 ins; 0 del; 0 mod; 563 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 6951 : 8066647: new hotspot build - hs25.40-b23
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/interp_masm_ppc_64.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
231 lines changed: 226 ins; 2 del; 3 mod; 2251 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/interp_masm_ppc_64.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
6 lines changed: 6 ins; 0 del; 0 mod; 302 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/macroAssembler_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
35 lines changed: 14 ins; 10 del; 11 mod; 3146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/macroAssembler_ppc.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
1 line changed: 1 ins; 0 del; 0 mod; 716 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/nativeInst_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
10 lines changed: 4 ins; 4 del; 2 mod; 385 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/ppc.ad

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
6 lines changed: 2 ins; 0 del; 4 mod; 12121 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/templateInterpreter_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
17 lines changed: 10 ins; 2 del; 5 mod; 1832 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/templateTable_ppc_64.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
16 lines changed: 16 ins; 0 del; 0 mod; 4086 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/ppc/vm/vm_version_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
33 lines changed: 31 ins; 0 del; 2 mod; 486 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/cpu/x86/vm/c1_Runtime1_x86.cpp

rev 6954 : 8066900: Array Out Of Bounds Exception causes variable corruption
Summary: Fix FP registers save/restore during exception handling
Reviewed-by: kvn, vlivanov
2 lines changed: 0 ins; 0 del; 2 mod; 1848 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/aix/vm/os_aix.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
146 lines changed: 33 ins; 44 del; 69 mod; 5144 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os/aix/vm/os_aix.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
1 line changed: 0 ins; 0 del; 1 mod; 384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/aix_ppc/vm/os_aix_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
5 lines changed: 1 ins; 0 del; 4 mod; 561 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/aix_ppc/vm/os_aix_ppc.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
3 lines changed: 0 ins; 0 del; 3 mod; 32 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/aix_ppc/vm/prefetch_aix_ppc.inline.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
3 lines changed: 0 ins; 0 del; 3 mod; 55 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/aix_ppc/vm/threadLS_aix_ppc.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
3 lines changed: 0 ins; 0 del; 3 mod; 33 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/aix_ppc/vm/thread_aix_ppc.hpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
3 lines changed: 0 ins; 0 del; 3 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/os_cpu/linux_ppc/vm/os_linux_ppc.cpp

rev 6962 : 8066964: ppc64: argument and return type profiling, fix problem with popframe
Reviewed-by: roland, kvn
1 line changed: 0 ins; 0 del; 1 mod; 613 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/classFileParser.cpp

rev 6955 : 8065634: Crash in InstanceKlass::clean_method_data when _method is NULL
Reviewed-by: coleenp, hseigel, poonam
55 lines changed: 42 ins; 2 del; 11 mod; 5213 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/classFileParser.hpp

rev 6955 : 8065634: Crash in InstanceKlass::clean_method_data when _method is NULL
Reviewed-by: coleenp, hseigel, poonam
4 lines changed: 4 ins; 0 del; 0 mod; 490 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/interpreter/interpreterRuntime.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
12 lines changed: 12 ins; 0 del; 0 mod; 1295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/memory/filemap.cpp

rev 6952 : 8066670: PrintSharedArchiveAndExit does not exit the VM when the archive is invalid
Summary: in FileMapInfo::fail_continue do not set UseSharedSpaces = false
Reviewed-by: dholmes, ccheung
6 lines changed: 3 ins; 3 del; 0 mod; 758 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/memory/metaspaceShared.cpp

rev 6952 : 8066670: PrintSharedArchiveAndExit does not exit the VM when the archive is invalid
Summary: in FileMapInfo::fail_continue do not set UseSharedSpaces = false
Reviewed-by: dholmes, ccheung
1 line changed: 0 ins; 0 del; 1 mod; 1146 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/memory/universe.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
8 lines changed: 7 ins; 0 del; 1 mod; 1528 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/memory/universe.hpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
2 lines changed: 2 ins; 0 del; 0 mod; 495 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/connode.cpp

rev 6960 : 8066775: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
Summary: bad assumption on graph shape in CastIINode::Value if that part of the graph is becoming dead.
Reviewed-by: kvn
2 lines changed: 1 ins; 0 del; 1 mod; 1472 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/ifnode.cpp

rev 6959 : 8066103: C2's range check smearing allows out of bound array accesses
Summary: range check smearing uncorrectly adjust first range check in a list of range checks to cover all of them
Reviewed-by: jrose, kvn, iveresov
140 lines changed: 90 ins; 27 del; 23 mod; 1094 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/loopopts.cpp

rev 6953 : 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
Summary: PhaseIdealLoop::split_if_with_blocks_post() shoulnd't reorder range checks adjusted by range check smearing
Reviewed-by: kvn, jrose
11 lines changed: 5 ins; 0 del; 6 mod; 2782 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/macro.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
5 lines changed: 4 ins; 0 del; 1 mod; 2575 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/deoptimization.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
rev 6958 : 8067144: SIGSEGV with +TraceDeoptimization in Deoptimization::print_objects
Summary: -XX:+TraceDeoptimization tries to print realloc'ed objects even when there are none
Reviewed-by: kvn
101 lines changed: 62 ins; 7 del; 32 mod; 1973 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/deoptimization.hpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
5 lines changed: 1 ins; 0 del; 4 mod; 384 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/sharedRuntime.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
1 line changed: 1 ins; 0 del; 0 mod; 3015 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/thread.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
1 line changed: 1 ins; 0 del; 0 mod; 4677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/thread.hpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
10 lines changed: 10 ins; 0 del; 0 mod; 2001 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/vframeArray.cpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
22 lines changed: 10 ins; 1 del; 11 mod; 604 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/vframeArray.hpp

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
13 lines changed: 10 ins; 0 del; 3 mod; 217 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/test/runtime/CheckEndorsedAndExtDirs/EndorsedExtDirs.java

rev 6961 : 8067232: [TESTBUG] runtime/CheckEndorsedAndExtDirs/EndorsedExtDirs.java fails with ClassNotFoundException
Summary: Added explicit build instructions for test library
Reviewed-by: minqi, mchung, jiangli
1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/exceptions/SumTest.java

rev 6954 : 8066900: Array Out Of Bounds Exception causes variable corruption
Summary: Fix FP registers save/restore during exception handling
Reviewed-by: kvn, vlivanov
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/rangechecks/TestRangeCheckSmearing.java

rev 6959 : 8066103: C2's range check smearing allows out of bound array accesses
Summary: range check smearing uncorrectly adjust first range check in a list of range checks to cover all of them
Reviewed-by: jrose, kvn, iveresov
436 lines changed: 436 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/rangechecks/TestRangeCheckSmearingLoopOpts.java

rev 6953 : 8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
Summary: PhaseIdealLoop::split_if_with_blocks_post() shoulnd't reorder range checks adjusted by range check smearing
Reviewed-by: kvn, jrose
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/uncommontrap/TestDeoptOOM.java

rev 6957 : 6898462: The escape analysis with G1 cause crash assertion src/share/vm/runtime/vframeArray.cpp:94
Summary: OOM during reallocation of scalar replaced objects in deoptimization causes crashes
Reviewed-by: kvn, jrose
426 lines changed: 426 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/uncommontrap/TraceDeoptimizationNoRealloc.java

rev 6958 : 8067144: SIGSEGV with +TraceDeoptimization in Deoptimization::print_objects
Summary: -XX:+TraceDeoptimization tries to print realloc'ed objects even when there are none
Reviewed-by: kvn
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/runtime/SharedArchiveFile/PrintSharedArchiveAndExit.java

rev 6952 : 8066670: PrintSharedArchiveAndExit does not exit the VM when the archive is invalid
Summary: in FileMapInfo::fail_continue do not set UseSharedSpaces = false
Reviewed-by: dholmes, ccheung
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).