Code Review for hs25.40-b22-jdk8u40-b18

Prepared by:amurillo on Fri Dec 5 10:16:44 PST 2014
Workspace:hs25.40-b22/hs25.40-b22-jdk8u40-b18
Compare against: jdk8u/jdk8u
Summary of changes: 1046 lines changed: 521 ins; 465 del; 60 mod; 38186 unchg
Patch of changes: hs25.40-b22-jdk8u40-b18.patch
Author comments:
8007993: hotspot.log w/ enabled LogCompilation can be an invalid XML
8035893: JVM_GetVersionInfo fails to zero structure
8042235: redefining method used by multiple MethodHandles crashes VM
8054478: C2: Incorrectly compiled char[] array access crashes JVM
8058448: Disable JPRT submissions from the hotspot repo
8062742: compiler/EliminateAutoBox/UnsignedLoads.java fails with client vm
8065618: C2 RA incorrectly removes kill projections
8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs
8066045: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
8066061: new hotspot build - hs25.40-b22
8066199: C2 escape analysis prevents VM from exiting quickly
8066649: 8u backport for 8065618 is incorrect
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/.hgtags

rev 6949 : Added tag hs25.40-b22 for changeset bc5a90a4db47
1 line changed: 1 ins; 0 del; 0 mod; 561 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/make/hotspot_version

rev 6932 : 8066061: new hotspot build - hs25.40-b22
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/javaClasses.cpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
27 lines changed: 24 ins; 0 del; 3 mod; 3565 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/classfile/javaClasses.hpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
4 lines changed: 3 ins; 0 del; 1 mod; 1445 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/compiler/compileBroker.cpp

rev 6935 : 8007993: hotspot.log w/ enabled LogCompilation can be an invalid XML
Summary: Open compilation log files in write-mode and close before deletion attempt.
Reviewed-by: vlivanov
1 line changed: 0 ins; 0 del; 1 mod; 2412 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/compiler/compileLog.cpp

rev 6935 : 8007993: hotspot.log w/ enabled LogCompilation can be an invalid XML
Summary: Open compilation log files in write-mode and close before deletion attempt.
Reviewed-by: vlivanov
5 lines changed: 2 ins; 1 del; 2 mod; 331 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.cpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
21 lines changed: 7 ins; 8 del; 6 mod; 3806 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/oops/instanceKlass.hpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
2 lines changed: 0 ins; 1 del; 1 mod; 1346 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/connode.cpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
95 lines changed: 95 ins; 0 del; 0 mod; 1378 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/connode.hpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
16 lines changed: 15 ins; 0 del; 1 mod; 767 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/escape.cpp

rev 6944 : 8066199: C2 escape analysis prevents VM from exiting quickly
Summary: Check for safepoint and block during EA Connection graph construction.
Reviewed-by: roland, vlivanov, shade
3 lines changed: 3 ins; 0 del; 0 mod; 3399 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/ifg.cpp

rev 6942 : 8065618: C2 RA incorrectly removes kill projections
Summary: Don't remove KILL projections if their "defining" nodes have SCMemProj projection (memory side effects).
Reviewed-by: iveresov, roland
rev 6945 : 8066649: 8u backport for 8065618 is incorrect
Summary: The new code in 8u backport should guard the execution of the following code instead of return.
Reviewed-by: iveresov
31 lines changed: 20 ins; 0 del; 11 mod; 795 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/loopTransform.cpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
32 lines changed: 32 ins; 0 del; 0 mod; 2795 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/loopnode.hpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
2 lines changed: 2 ins; 0 del; 0 mod; 1118 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/phaseX.cpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
rev 6937 : 8066045: opto/node.hpp:355, assert(i < _max) failed: oob: i=1, _max=1
Summary: code in PhaseIterGVN::add_users_to_worklist() from 8054478 makes incorrect assumption about graph shape
Reviewed-by: iveresov
37 lines changed: 32 ins; 3 del; 2 mod; 1829 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/subnode.cpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
2 lines changed: 0 ins; 2 del; 0 mod; 1466 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/opto/subnode.hpp

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
2 lines changed: 0 ins; 2 del; 0 mod; 563 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/prims/jvm.cpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
rev 6946 : 8035893: JVM_GetVersionInfo fails to zero structure
Reviewed-by: sla, zgu
27 lines changed: 18 ins; 0 del; 9 mod; 4531 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/prims/methodHandles.cpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
54 lines changed: 3 ins; 37 del; 14 mod; 1362 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/prims/methodHandles.hpp

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
6 lines changed: 0 ins; 4 del; 2 mod; 248 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/src/share/vm/runtime/arguments.cpp

rev 6940 : 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs
Reviewed-by: hseigel, ccheung
1 line changed: 0 ins; 0 del; 1 mod; 4307 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/test/compiler/EliminateAutoBox/UnsignedLoads.java

rev 6939 : 8062742: compiler/EliminateAutoBox/UnsignedLoads.java fails with client vm
Reviewed-by: kvn, rbackman, anoll, vlivanov, iignatyev
Contributed-by: tatiana.pivovarova@oracle.com
1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw hotspot/test/runtime/CheckEndorsedAndExtDirs/EndorsedExtDirs.java

rev 6940 : 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs
Reviewed-by: hseigel, ccheung
36 lines changed: 32 ins; 0 del; 4 mod; 56 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/jsr292/RedefineMethodUsedByMultipleMethodHandles.java

rev 6933 : 8042235: redefining method used by multiple MethodHandles crashes VM
Summary: note all MemberNames created on internal list for adjusting method entries.
Reviewed-by: sspitsyn, dcubed, lfoltan
174 lines changed: 174 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw hotspot/test/compiler/loopopts/TestDeadBackbranchArrayAccess.java

rev 6936 : 8054478: C2: Incorrectly compiled char[] array access crashes JVM
Summary: dead backbranch in main loop results in erroneous array access
Reviewed-by: kvn, iveresov
58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- ----- --- hotspot/make/jprt.properties

407 lines changed: 0 ins; 407 del; 0 mod; 0 unchg

This code review page was prepared using /export/pub/bin/webrev (vers 25.6-hg+openjdk.java.net).