Code Review for hs25.40-b04-jdk8u40-b01

Prepared by:amurillo on Thu Aug 7 15:07:35 PDT 2014
Workspace:hs25.40-b04-jdk8u40-b01/hotspot
Compare against: jdk8u/jdk8u/hotspot
Compare against version:6419
Summary of changes: 1368 lines changed: 938 ins; 359 del; 71 mod; 30752 unchg
Patch of changes: hotspot.patch
Author comments:
8024366: Make UseNUMA enable UseNUMAInterleaving
8029070: memory leak in jmm_SetVMGlobal
8038756: new WB API :: get/setVMFlag
8038928: gc/g1/TestGCLogMessages.java fail with "[Evacuation Failure'
8039489: Refactor test framework for dynamic VM options
8040921: Uninitialised memory in hotspot/src/share/vm/c1/c1_LinearScan.cpp
8046233: VerifyError on backward branch
8046715: Add a way to verify an extended set of command line options
8046783: Add hidden field to methods for event based tracing
8049252: VerifyStack logic in Deoptimization::unpack_frames does not expect to see invoke bc at the top frame during normal deoptimization
8049684: pstack crashes on java core dump
8051012: Regression in verifier for <init> method call from inside of a branch
8051910: new hotspot build - hs25.40-b03
8054159: new hotspot build - hs25.40-b04
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw .hgtags

rev 6426 : Added tag hs25.40-b03 for changeset e2976043eac3
rev 6438 : Added tag hs25.40-b04 for changeset cb95655ef06f
2 lines changed: 2 ins; 0 del; 0 mod; 502 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw make/hotspot_version

rev 6420 : 8051910: new hotspot build - hs25.40-b03
Reviewed-by: jcoomes
rev 6427 : 8054159: new hotspot build - hs25.40-b04
Reviewed-by: jcoomes
1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/bsd/dtrace/libjvm_db.c

rev 6421 : 8049684: pstack crashes on java core dump
Reviewed-by: sundar, sspitsyn
3 lines changed: 3 ins; 0 del; 0 mod; 1532 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/os/solaris/dtrace/libjvm_db.c

rev 6421 : 8049684: pstack crashes on java core dump
Reviewed-by: sundar, sspitsyn
3 lines changed: 3 ins; 0 del; 0 mod; 1532 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_LinearScan.cpp

rev 6431 : 8040921: Uninitialised memory in hotspot/src/share/vm/c1/c1_LinearScan.cpp
Summary: Fixed parfait initialization issue.
Reviewed-by: kvn, twisti
23 lines changed: 10 ins; 13 del; 0 mod; 6714 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/stackMapFrame.cpp

rev 6433 : 8046233: VerifyError on backward branch
Summary: Remove check that causes the VerifyError
Reviewed-by: dholmes, coleenp, acorn
16 lines changed: 0 ins; 15 del; 1 mod; 399 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/stackMapFrame.hpp

rev 6433 : 8046233: VerifyError on backward branch
Summary: Remove check that causes the VerifyError
Reviewed-by: dholmes, coleenp, acorn
5 lines changed: 0 ins; 4 del; 1 mod; 299 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/stackMapTable.cpp

rev 6429 : 8051012: Regression in verifier for <init> method call from inside of a branch
Summary: Fix stackmap matching for branches.
Reviewed-by: coleenp, lfoltan, acorn
rev 6433 : 8046233: VerifyError on backward branch
Summary: Remove check that causes the VerifyError
Reviewed-by: dholmes, coleenp, acorn
27 lines changed: 2 ins; 16 del; 9 mod; 411 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/stackMapTable.hpp

rev 6429 : 8051012: Regression in verifier for <init> method call from inside of a branch
Summary: Fix stackmap matching for branches.
Reviewed-by: coleenp, lfoltan, acorn
rev 6433 : 8046233: VerifyError on backward branch
Summary: Remove check that causes the VerifyError
Reviewed-by: dholmes, coleenp, acorn
6 lines changed: 0 ins; 4 del; 2 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/verifier.cpp

rev 6429 : 8051012: Regression in verifier for <init> method call from inside of a branch
Summary: Fix stackmap matching for branches.
Reviewed-by: coleenp, lfoltan, acorn
11 lines changed: 0 ins; 9 del; 2 mod; 2761 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/verifier.hpp

rev 6429 : 8051012: Regression in verifier for <init> method call from inside of a branch
Summary: Fix stackmap matching for branches.
Reviewed-by: coleenp, lfoltan, acorn
16 lines changed: 0 ins; 16 del; 0 mod; 450 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/whitebox.cpp

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
178 lines changed: 172 ins; 4 del; 2 mod; 730 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 6424 : 8046715: Add a way to verify an extended set of command line options
Summary: Added arguments_ext.cpp to make place for initialization of extended features
Reviewed-by: sla, mgronlun
rev 6428 : 8024366: Make UseNUMA enable UseNUMAInterleaving
Reviewed-by: mgerdin
Contributed-by: shrinivas.joshi@oracle.com
18 lines changed: 10 ins; 2 del; 6 mod; 3986 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.hpp

rev 6424 : 8046715: Add a way to verify an extended set of command line options
Summary: Added arguments_ext.cpp to make place for initialization of extended features
Reviewed-by: sla, mgronlun
1 line changed: 1 ins; 0 del; 0 mod; 593 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/deoptimization.cpp

rev 6430 : 8049252: VerifyStack logic in Deoptimization::unpack_frames does not expect to see invoke bc at the top frame during normal deoptimization
Summary: Add missing check for reexecute flag to VerifyStack code.
Reviewed-by: roland
1 line changed: 0 ins; 0 del; 1 mod; 2009 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.cpp

rev 6435 : 8029070: memory leak in jmm_SetVMGlobal
Reviewed-by: kvn, dholmes
rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
15 lines changed: 0 ins; 3 del; 12 mod; 852 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 6435 : 8029070: memory leak in jmm_SetVMGlobal
Reviewed-by: kvn, dholmes
rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
26 lines changed: 2 ins; 0 del; 24 mod; 3923 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals_extension.hpp

rev 6435 : 8029070: memory leak in jmm_SetVMGlobal
Reviewed-by: kvn, dholmes
1 line changed: 1 ins; 0 del; 0 mod; 211 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/management.cpp

rev 6435 : 8029070: memory leak in jmm_SetVMGlobal
Reviewed-by: kvn, dholmes
4 lines changed: 3 ins; 0 del; 1 mod; 2375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/trace/tracetypes.xml

rev 6422 : 8046783: Add hidden field to methods for event based tracing
Reviewed-by: sla, mgronlun
1 line changed: 1 ins; 0 del; 0 mod; 375 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/gc/arguments/TestDynMaxHeapFreeRatio.java

rev 6425 : 8039489: Refactor test framework for dynamic VM options
Reviewed-by: jmasa, ehelin, jwilhelm
67 lines changed: 42 ins; 24 del; 1 mod; 39 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/gc/arguments/TestDynMinHeapFreeRatio.java

rev 6425 : 8039489: Refactor test framework for dynamic VM options
Reviewed-by: jmasa, ehelin, jwilhelm
62 lines changed: 40 ins; 18 del; 4 mod; 40 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/gc/g1/TestGCLogMessages.java

rev 6423 : 8038928: gc/g1/TestGCLogMessages.java fail with "[Evacuation Failure'
Reviewed-by: ysr, brutisso, tschatzl
7 lines changed: 0 ins; 6 del; 1 mod; 151 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/runtime/7116786/Test7116786.java

rev 6433 : 8046233: VerifyError on backward branch
Summary: Remove check that causes the VerifyError
Reviewed-by: dholmes, coleenp, acorn
3 lines changed: 1 ins; 0 del; 2 mod; 487 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
14 lines changed: 13 ins; 0 del; 1 mod; 156 unchg

------ ------ ------ ------ ------ --- New Patch Raw src/share/vm/runtime/arguments_ext.cpp

rev 6424 : 8046715: Add a way to verify an extended set of command line options
Summary: Added arguments_ext.cpp to make place for initialization of extended features
Reviewed-by: sla, mgronlun
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary/com/oracle/java/testlibrary/DynamicVMOption.java

rev 6425 : 8039489: Refactor test framework for dynamic VM options
Reviewed-by: jmasa, ehelin, jwilhelm
165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/BooleanTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/DoubleTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/IntxTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/StringTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/Uint64Test.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/UintxTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/testlibrary_tests/whitebox/vm_flags/VmFlagTest.java

rev 6436 : 8038756: new WB API :: get/setVMFlag
Reviewed-by: vlivanov, sla
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- test/testlibrary/com/oracle/java/testlibrary/DynamicVMOptionChecker.java

121 lines changed: 0 ins; 121 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ Old --- Patch --- test/testlibrary/com/oracle/java/testlibrary/TestDynamicVMOption.java

104 lines changed: 0 ins; 104 del; 0 mod; 0 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).